...

• Initial feedback may be minor things, such as:

  • Choice of variable names

  • Code format issues

• Eventually, you will migrate to:

  • Spotting design issues

  • Providing better implementation choices

Code Review Categories

• Is the intent of the API at the header file clear?

• Functions

  • Should be small

  • Code should be modular

  • Does the function name match the actual code of the function?

• Module review

  • Can the module be broken up?

  • Any duplicated code? (DRY violation)

  • Can we re-use any existing code?

• Unit-test review

  • One type of test per test function

  • Minimal “setup”, and maximum code-reuse

Code Approval's Responsibility

...